License Update #1374
Merged
License Update #1374
+23
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eltonmesquita
requested changes
Oct 5, 2021
|
Hi @eltonmesquita alright, I'll keep the naming convention into uppercase. Let me push the changes. |
eltonmesquita
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
I'll get this merged, but it'd be nice if you could revert the commit or use a fixup commit the next time you've got something reverted.
Besides that, very nice work! Thanks for that
|
Note: you should preserve the previous license text in the project, if you have had contributors prior to this. See: vcr/vcr#804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I just update the license of animate.css as mentioned here: #1355